Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes signal instance deduplication check. #4012

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Fixes signal instance deduplication check. #4012

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
343da79
Deduplicating signal instances should only occur when those instances…
metroid-samus Nov 20, 2023
9ae594c
Merge branch 'master' into bug/deduplicate-only-signal-instances-with…
kevgliss Nov 27, 2023
33e6388
Checks for existing cases before signal deduplication.
metroid-samus Nov 27, 2023
3635fc5
Merge branch 'master' into bug/deduplicate-only-signal-instances-with…
metroid-samus Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/dispatch/signal/flows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ def _should_update_signal_message(signal_instance: SignalInstance) -> bool:
"""
global _last_nonupdated_signal_cache

if signal_instance.case_id:
metroid-samus marked this conversation as resolved.
Show resolved Hide resolved
return False

case_id = str(signal_instance.case_id)

if case_id not in _last_nonupdated_signal_cache:
Expand Down
Loading