Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues with Signals table after migration to Vue3 #3922

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Fixes issues with Signals table after migration to Vue3 #3922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dispatch/static/dispatch/src/signal/SignalPopover.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<template #activator="{ props }">
<v-chip pill size="small" v-bind="props">
<template #prepend>
<v-avatar color="teal">
<v-avatar color="teal" start>
{{ initials(value.name) }}
</v-avatar>
</template>
Expand Down
28 changes: 14 additions & 14 deletions src/dispatch/static/dispatch/src/signal/TableInstance.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,20 @@
:loading="loading"
loading-text="Loading... Please wait"
>
<template #item.create_case="{ value }">
<v-checkbox-btn model="value.signal.create_case" disabled />
<template #item.signal.create_case="{ value }">
<v-checkbox-btn :model-value="value" disabled />
</template>
<template #item.case="{ value }">
<case-popover v-if="value" :value="value" />
</template>
<template #item.signal="{ value }">
<signal-popover :value="value" />
</template>
<template #item.canary="{ value }">
<v-checkbox-btn v-model="value.signal.canary" disabled />
<template #item.signal.canary="{ value }">
<v-checkbox-btn :model-value="value" disabled />
</template>
<template #item.project.name="{ item, value }">
<v-chip size="small" :color="item.project.color">
<template #item.signal.project.name="{ item, value }">
<v-chip size="small" :color="item.signal.project.color">
{{ value }}
</v-chip>
</template>
Expand Down Expand Up @@ -107,14 +107,14 @@ export default {
data() {
return {
headers: [
{ text: "Create Case", value: "create_case", sortable: false },
{ text: "Case", value: "case", sortable: false },
{ text: "Signal Definition", value: "signal", sortable: false },
{ text: "Canary", value: "canary", sortable: false },
{ text: "Filter Action", value: "filter_action", sortable: true },
{ text: "Project", value: "project.name", sortable: true },
{ text: "Created At", value: "created_at" },
{ text: "", value: "data-table-actions", sortable: false, align: "end" },
{ title: "Create Case", value: "signal.create_case", sortable: false },
{ title: "Case", value: "case", sortable: false },
{ title: "Signal Definition", value: "signal", sortable: false },
{ title: "Canary", value: "signal.canary", sortable: false },
{ title: "Filter Action", value: "filter_action", sortable: true },
{ title: "Project", value: "signal.project.name", sortable: true },
{ title: "Created At", value: "created_at" },
{ title: "", value: "data-table-actions", sortable: false, align: "end" },
],
}
},
Expand Down
Loading