Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where entity types created via Modal don't appear in combobox #3855

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

wssheldon
Copy link
Contributor

The issue stemmed from us not returning entity types with the type single:

+ scope: ["multiple", "single"]

Which is the default type when created via the + -> Modal creation dialog (from within the definition edit sheet).

@wssheldon wssheldon added the bug Something isn't working label Oct 6, 2023
@wssheldon wssheldon requested a review from mvilanova October 6, 2023 19:56
@wssheldon
Copy link
Contributor Author

@kevgliss FYI, in case this change doesn't track w/ what you expected for the all/multiple/single categories you added. This is just to resolve the immediate UX issue and I think it's okay for now. I need to think about it more.

@wssheldon wssheldon merged commit 3870191 into master Oct 6, 2023
9 checks passed
@wssheldon wssheldon deleted the bugfix/entity-type-view branch October 6, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants