Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making experience textbox from oncall end-of-shift feedback optional #3799

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Making experience textbox from oncall end-of-shift feedback optional #3799

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28a5d34
Removing experience textbox
whitdog47 Sep 20, 2023
65ccaba
Merge branch 'master' into enhancement/remove-experience-from-oncall-…
whitdog47 Sep 21, 2023
44f65b0
Updating field to optional instead of removing
whitdog47 Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/dispatch/plugins/dispatch_slack/feedback/interactive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ def oncall_shift_feedback_input(
initial_value=initial_value,
multiline=True,
placeholder="How would you describe your experience?",
optional=True,
),
label=label,
**kwargs,
Expand Down Expand Up @@ -381,7 +382,7 @@ def handle_oncall_shift_feedback_submission_event(

ack_oncall_shift_feedback_submission_event(ack=ack)

feedback = form_data.get(ServiceFeedbackNotificationBlockIds.feedback_input)
feedback = form_data.get(ServiceFeedbackNotificationBlockIds.feedback_input, "")
rating = form_data.get(ServiceFeedbackNotificationBlockIds.rating_select, {}).get("value")

# metadata is organization_slug|project_id|schedule_id|shift_end_at|reminder_id
Expand Down
Loading