Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SQLAlchemy pool pre ping #3774

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Add support for SQLAlchemy pool pre ping #3774

merged 3 commits into from
Sep 12, 2023

Conversation

Cinojose
Copy link
Contributor

Adding support for DB pool_pre_ping to fix db disconnects. We've been getting quite a bit of OperationalError lately and this seems to fix.

We set the flag to True in env.

(psycopg2.OperationalError) SSL SYSCALL error: EOF detected
(Background on this error at: http://sqlalche.me/e/13/e3q8)

More reading
https://docs.sqlalchemy.org/en/20/errors.html#operationalerror

@whitdog47 whitdog47 added the bug Something isn't working label Sep 12, 2023
@whitdog47 whitdog47 self-requested a review September 12, 2023 19:14
whitdog47
whitdog47 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@whitdog47 whitdog47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@whitdog47 whitdog47 merged commit d2724cc into Netflix:master Sep 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitdog47 whitdog47 whitdog47 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cinojose @whitdog47