Allow a restricted incident priority for stable status

src/dispatch/database/revisions/tenant/versions/2023-09-07_0356472ea980.py

@@ -0,0 +1,29 @@
+"""Adds new restrict to stable incident priority id
+
+Revision ID: 0356472ea980
+Revises: 1dd78f49e303
+Create Date: 2023-09-01 15:30:52.512886
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+# revision identifiers, used by Alembic.
+revision = "0356472ea980"
+down_revision = "1dd78f49e303"
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.add_column("project", sa.Column("restrict_stable_to_id", sa.Integer(), nullable=True))
+    op.create_foreign_key(None, "project", "incident_priority", ["restrict_stable_to_id"], ["id"])
+    # ### end Alembic commands ###
+
+
+def downgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.drop_constraint(None, "project", type_="foreignkey")
+    op.drop_column("project", "restrict_stable_to_id")
+    # ### end Alembic commands ###

src/dispatch/incident/models.py

@@ -239,6 +239,7 @@ class ProjectRead(DispatchBase):
     id: Optional[PrimaryKey]
     name: NameStr
     color: Optional[str]
+    restrict_stable_to: Optional[IncidentPriorityRead] = None
 
 
 class CaseRead(DispatchBase):

src/dispatch/incident/priority/models.py

@@ -9,7 +9,6 @@
 
 from dispatch.database.core import Base, ensure_unique_default_per_project
 from dispatch.models import DispatchBase, NameStr, ProjectMixin, PrimaryKey, Pagination
-from dispatch.project.models import ProjectRead
 
 
 class IncidentPriority(Base, ProjectMixin):
@@ -36,6 +35,11 @@ class IncidentPriority(Base, ProjectMixin):
 listen(IncidentPriority.default, "set", ensure_unique_default_per_project)
 
 
+class ProjectRead(DispatchBase):
+    id: Optional[PrimaryKey]
+    name: NameStr
+
+
 # Pydantic models...
 class IncidentPriorityBase(DispatchBase):
     name: NameStr

src/dispatch/incident/service.py

@@ -290,10 +290,8 @@ def update(*, db_session, incident: Incident, incident_in: IncidentUpdate) -> In
     )
 
     if incident_in.status == IncidentStatus.stable:
-        incident_priority = incident_priority_service.get_default(
-            db_session=db_session,
-            project_id=incident.project.id,
-        )
+        if incident.project.restrict_stable_to:
+            incident_priority = incident.project.restrict_stable_to
     else:
         incident_priority = incident_priority_service.get_by_name_or_default(
             db_session=db_session,

src/dispatch/project/models.py

@@ -12,6 +12,10 @@
 from dispatch.models import DispatchBase, NameStr, PrimaryKey, Pagination
 
 from dispatch.organization.models import Organization, OrganizationRead
+from dispatch.incident.priority.models import (
+    IncidentPriority,
+    IncidentPriorityRead,
+)
 
 
 class Project(Base):
@@ -37,6 +41,13 @@ class Project(Base):
 
     send_daily_reports = Column(Boolean)
 
+    restrict_stable_to_id = Column(Integer, nullable=True)
+    restrict_stable_to = relationship(
+        IncidentPriority,
+        foreign_keys=[restrict_stable_to_id],
+        primaryjoin="IncidentPriority.id == Project.restrict_stable_to_id",
+    )
+
     @hybrid_property
     def slug(self):
         return slugify(self.name)
@@ -65,10 +76,12 @@ class ProjectCreate(ProjectBase):
 
 class ProjectUpdate(ProjectBase):
     send_daily_reports: Optional[bool] = Field(True, nullable=True)
+    restrict_stable_to_id: Optional[int]
 
 
 class ProjectRead(ProjectBase):
     id: Optional[PrimaryKey]
+    restrict_stable_to: Optional[IncidentPriorityRead] = None
 
 
 class ProjectPagination(Pagination):

src/dispatch/static/dispatch/src/incident/DetailsTab.vue

@@ -77,15 +77,27 @@
         <incident-severity-select v-model="incident_severity" :project="project" />
       </v-flex>
       <v-flex xs6>
-        <incident-priority-select v-model="incident_priority" :project="project" />
+        <ValidationProvider
+          name="Incident Priority"
+          rules="stableRestrictedPriority:@status,@project"
+          immediate
+        >
+          <incident-priority-select
+            v-model="incident_priority"
+            :project="project"
+            :status="status"
+          />
+        </ValidationProvider>
       </v-flex>
       <v-flex xs6>
-        <v-select
-          v-model="status"
-          label="Status"
-          :items="statuses"
-          hint="The status of the incident."
-        />
+        <ValidationProvider name="status" rules="alwaysTrue" immediate>
+          <v-select
+            v-model="status"
+            label="Status"
+            :items="statuses"
+            hint="The status of the incident."
+          />
+        </ValidationProvider>
       </v-flex>
       <v-flex xs6>
         <v-select
@@ -120,6 +132,11 @@
       <v-flex xs12>
         <case-filter-combobox label="Cases" v-model="cases" />
       </v-flex>
+      <v-flex xs12 v-show="false">
+        <ValidationProvider name="project" rules="alwaysTrue" immediate>
+          <v-text-field v-model="project" />
+        </ValidationProvider>
+      </v-flex>
     </v-layout>
   </v-container>
 </template>
@@ -144,6 +161,25 @@ extend("required", {
   message: "This field is required",
 })
 
+extend("stableRestrictedPriority", {
+  params: ["status", "project"],
+  validate(value, { status, project }) {
+    if (!project) return true
+    const restrictStableTo = project.restrict_stable_to
+    if (!restrictStableTo) return true
+    if (status == "Stable" && value.name != restrictStableTo.name) {
+      return false
+    }
+    return true
+  },
+})
+
+extend("alwaysTrue", {
+  validate() {
+    return true
+  },
+})
+
 export default {
   name: "IncidentDetailsTab",
 

src/dispatch/static/dispatch/src/incident/priority/IncidentPrioritySelect.vue

@@ -7,6 +7,7 @@
     label="Priority"
     return-object
     :loading="loading"
+    :error-messages="show_error"
   >
     <template #item="data">
       <template>
@@ -38,6 +39,10 @@ export default {
       type: [Object],
       default: null,
     },
+    status: {
+      type: String,
+      default: "",
+    },
   },
 
   data() {
@@ -56,6 +61,15 @@ export default {
         this.$emit("input", value)
       },
     },
+    show_error() {
+      if (!this.project) return null
+      const restrictStableTo = this.project.restrict_stable_to
+      if (!restrictStableTo) return null
+      if (this.status == "Stable" && this.value.name != restrictStableTo.name) {
+        return `Priority must be ${restrictStableTo.name} for Stable incidents`
+      }
+      return null
+    },
   },
 
   methods: {
@@ -101,7 +115,7 @@ export default {
   created() {
     this.fetchData()
     this.$watch(
-      (vm) => [vm.project],
+      (vm) => [vm.project, vm.status],
       () => {
         this.fetchData()
       }

src/dispatch/static/dispatch/src/incident/priority/Table.vue

@@ -17,6 +17,9 @@
         <v-btn color="info" class="mr-2" @click="createEditShow()"> New </v-btn>
       </v-col>
     </v-row>
+    <v-row no-gutters>
+      <div class="text-body-1 ml-4 mt-3">Incident priority types</div>
+    </v-row>
     <v-row no-gutters>
       <v-col>
         <v-card elevation="0">
@@ -68,6 +71,39 @@
         </v-card>
       </v-col>
     </v-row>
+    <v-divider />
+    <v-row no-gutters>
+      <v-col>
+        <div class="text-body-1 ml-4 mt-6">Incident priority settings</div>
+        <v-row align="start" no-gutters>
+          <v-col class="d-flex justify-start">
+            <v-checkbox
+              class="ml-10 mr-5"
+              v-model="restrictStable"
+              label="Restrict Stable status to this priority:"
+              @change="updateRestrictStable"
+            />
+            <v-tooltip max-width="500px" open-delay="50" bottom>
+              <template #activator="{ on }">
+                <v-icon v-on="on"> mdi-information </v-icon>
+              </template>
+              <span>
+                If activated, Dispatch will automatically change Stable incidents to this priority.
+                Also, users will not be permitted to change the priority on Stable incidents.
+              </span>
+            </v-tooltip>
+            <span max-width="500px">
+              <incident-priority-select
+                class="ml-4"
+                max-width="400px"
+                v-model="restrictStableTo"
+                :project="project[0]"
+              />
+            </span>
+          </v-col>
+        </v-row>
+      </v-col>
+    </v-row>
   </v-container>
 </template>
 
@@ -77,13 +113,15 @@ import { mapActions } from "vuex"
 
 import NewEditSheet from "@/incident/priority/NewEditSheet.vue"
 import SettingsBreadcrumbs from "@/components/SettingsBreadcrumbs.vue"
+import IncidentPrioritySelect from "@/incident/priority/IncidentPrioritySelect.vue"
 
 export default {
   name: "IncidentPriorityTable",
 
   components: {
     NewEditSheet,
     SettingsBreadcrumbs,
+    IncidentPrioritySelect,
   },
   data() {
     return {
@@ -98,6 +136,7 @@ export default {
         { text: "View Order", value: "view_order", sortable: true },
         { text: "", value: "data-table-actions", sortable: false, align: "end" },
       ],
+      restrictStable: false,
     }
   },
 
@@ -112,6 +151,7 @@ export default {
       "table.loading",
       "table.rows.items",
       "table.rows.total",
+      "restrictStableTo",
     ]),
     ...mapFields("route", ["query", "params"]),
   },
@@ -120,19 +160,34 @@ export default {
     this.project = [{ name: this.query.project }]
 
     this.getAll()
+    this.restrictStable = this.restrictStableTo != null
 
     this.$watch(
       (vm) => [vm.q, vm.itemsPerPage, vm.sortBy, vm.descending, vm.project],
       () => {
         this.page = 1
         this.$router.push({ query: { project: this.project[0].name } })
         this.getAll()
+        this.restrictStable = this.restrictStableTo != null
+      }
+    )
+
+    this.$watch(
+      (vm) => [vm.restrictStableTo],
+      () => {
+        this.restrictStable = this.restrictStableTo != null
+        this.updateRestrictStable(this.restrictStable)
       }
     )
   },
 
   methods: {
-    ...mapActions("incident_priority", ["getAll", "createEditShow", "removeShow"]),
+    ...mapActions("incident_priority", [
+      "getAll",
+      "createEditShow",
+      "removeShow",
+      "updateRestrictStable",
+    ]),
   },
 }
 </script>