lint: resolve eslint error level lint checks

Netflix · Nov 8, 2024 · f6e4cef · f6e4cef
1 parent 3a157bb
commit f6e4cef
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/dispatch/static/dispatch/src/auth/Mfa.vue b/src/dispatch/static/dispatch/src/auth/Mfa.vue
@@ -23,7 +23,7 @@
                 :type="alertType"
                 :icon="statusIcon"
                 class="mb-4"
-                border="left"
+                border="start"
               >
                 {{ statusMessage }}
               </v-alert>

diff --git a/src/dispatch/static/dispatch/src/tests/Mfa.spec.js b/src/dispatch/static/dispatch/src/tests/Mfa.spec.js
@@ -6,7 +6,6 @@ import * as directives from "vuetify/directives"
 import MfaVerification from "@/auth/mfa.vue"
 import authApi from "@/auth/api"
 
-// Mock vue-router
 vi.mock("vue-router", () => ({
   useRoute: () => ({
     query: {
@@ -17,7 +16,6 @@ vi.mock("vue-router", () => ({
   }),
 }))
 
-// Mock auth API
 vi.mock("@/auth/api", () => ({
   default: {
     verifyMfa: vi.fn(),
@@ -31,19 +29,24 @@ const vuetify = createVuetify({
 
 global.ResizeObserver = require("resize-observer-polyfill")
 
-const originalWindow = window
 const windowCloseMock = vi.fn()
+const originalClose = window.close
 
 beforeEach(() => {
   vi.useFakeTimers()
-  // @ts-ignore
-  window.close = windowCloseMock
+  Object.defineProperty(window, "close", {
+    value: windowCloseMock,
+    writable: true,
+  })
   vi.clearAllMocks()
 })
 
 afterEach(() => {
   vi.useRealTimers()
-  window = originalWindow
+  Object.defineProperty(window, "close", {
+    value: originalClose,
+    writable: true,
+  })
 })
 
 test("mounts correctly and starts verification automatically", async () => {