Merge branch 'master' into enhancement/allow-filter-dashboard-by-comm…

…ander
Netflix · Sep 28, 2023 · f2fc6f1 · f2fc6f1
2 parents 43d0e0d + dc37961
commit f2fc6f1
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/dispatch/plugins/dispatch_slack/feedback/interactive.py b/src/dispatch/plugins/dispatch_slack/feedback/interactive.py
@@ -275,7 +275,6 @@ def oncall_shift_feedback_input(
             initial_value=initial_value,
             multiline=True,
             placeholder="How would you describe your experience?",
-            optional=True,
         ),
         label=label,
         **kwargs,
@@ -382,7 +381,7 @@ def handle_oncall_shift_feedback_submission_event(
 
     ack_oncall_shift_feedback_submission_event(ack=ack)
 
-    feedback = form_data.get(ServiceFeedbackNotificationBlockIds.feedback_input, "")
+    feedback = form_data.get(ServiceFeedbackNotificationBlockIds.feedback_input)
     rating = form_data.get(ServiceFeedbackNotificationBlockIds.rating_select, {}).get("value")
 
     # metadata is organization_slug|project_id|schedule_id|shift_end_at|reminder_id