More eslint issues, unused vars, defining types, and deprecated veuti…

…fy props
Netflix · Nov 29, 2023 · e30b9f3 · e30b9f3
1 parent 33963e6
commit e30b9f3
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 14 deletions.
diff --git a/src/dispatch/static/dispatch/src/case/CaseSignalInstanceTab.vue b/src/dispatch/static/dispatch/src/case/CaseSignalInstanceTab.vue
@@ -91,14 +91,7 @@ watch(
   }
 )
 
-const headers = ref([
-  { title: "Signal", key: "signal", sortable: false },
-  { title: "Created At", key: "created_at" },
-  { title: "", key: "data-table-actions", sortable: false, align: "end" },
-])
-
 const selectItem = (item) => {
-  console.log("Got item", item)
   selectedItem.value = item
   router.push({ name: "SignalDetails", params: { signal_id: item.raw.id } })
 }

diff --git a/src/dispatch/static/dispatch/src/case/Page.vue b/src/dispatch/static/dispatch/src/case/Page.vue
@@ -20,7 +20,7 @@
 </template>
 
 <script setup lang="ts">
-import { ref, watch, watchEffect } from "vue"
+import { ref, watch } from "vue"
 import { useStore } from "vuex"
 
 import { useRoute } from "vue-router"

diff --git a/src/dispatch/static/dispatch/src/case/SignalInstanceNode.vue b/src/dispatch/static/dispatch/src/case/SignalInstanceNode.vue
@@ -1,8 +1,12 @@
 <script setup>
 import { Handle, Position } from "@vue-flow/core"
-import { ref, defineEmits } from "vue"
+import { defineEmits } from "vue"
 
-const props = defineProps(["label", "data"])
+
+const props = defineProps<{
+  label: string
+  data: any
+}>()
 
 const emit = defineEmits(["openViewer"])
 

diff --git a/src/dispatch/static/dispatch/src/components/AvatarStack.vue b/src/dispatch/static/dispatch/src/components/AvatarStack.vue
@@ -12,7 +12,7 @@
         {{ item }}
       </v-avatar>
 
-      <v-menu offset-y v-model="menu" :close-on-content-click="false">
+      <v-menu location="start" v-model="menu" :close-on-content-click="false">
         <template #activator="{ props }">
           <v-btn
             icon
@@ -46,8 +46,6 @@ export default {
   name: "AvatarStack",
   props: {
     modelValue: Array,
-    default: () => [],
-    required: true,
   },
   emits: ["update:modelValue"],
 

diff --git a/src/dispatch/static/dispatch/src/components/LockButton.vue b/src/dispatch/static/dispatch/src/components/LockButton.vue
@@ -31,7 +31,6 @@ import { ref, watch, computed } from "vue"
 import { useStore } from "vuex"
 import FancyTooltip from "@/components/FancyTooltip.vue"
 import CaseApi from "@/case/api"
-import { E } from "../../dist/assets/index.e9481c97"
 
 const props = defineProps({
   caseVisibility: {