Merge branch 'master' into enhancement/direct-link-to-timeline

Netflix · Sep 22, 2023 · b118752 · b118752
2 parents 7a481bb + db544b0
commit b118752
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/dispatch/plugins/dispatch_slack/feedback/interactive.py b/src/dispatch/plugins/dispatch_slack/feedback/interactive.py
@@ -275,6 +275,7 @@ def oncall_shift_feedback_input(
             initial_value=initial_value,
             multiline=True,
             placeholder="How would you describe your experience?",
+            optional=True,
         ),
         label=label,
         **kwargs,
@@ -381,7 +382,7 @@ def handle_oncall_shift_feedback_submission_event(
 
     ack_oncall_shift_feedback_submission_event(ack=ack)
 
-    feedback = form_data.get(ServiceFeedbackNotificationBlockIds.feedback_input)
+    feedback = form_data.get(ServiceFeedbackNotificationBlockIds.feedback_input, "")
     rating = form_data.get(ServiceFeedbackNotificationBlockIds.rating_select, {}).get("value")
 
     # metadata is organization_slug|project_id|schedule_id|shift_end_at|reminder_id