Skip to content

Commit

Permalink
Merge branch 'master' into enhancement/update_incident_cost
Browse files Browse the repository at this point in the history
  • Loading branch information
metroid-samus authored Mar 30, 2024
2 parents 7f68c48 + 4a61ae7 commit a516b50
Show file tree
Hide file tree
Showing 5 changed files with 71 additions and 70 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
# Minimum code coverage per file
COVERAGE_SINGLE: 50
# Minimum total code coverage
COVERAGE_TOTAL: 70
COVERAGE_TOTAL: 54
runs-on: ubuntu-latest
services:
postgres:
Expand Down Expand Up @@ -57,10 +57,9 @@ jobs:
# exit 1
fi
- name: Coverage total
# TODO: Change this recommendation into a requirement.
run: |
export COVERAGE_TOTAL=$(python -c "import json;print(json.load(open('coverage.json'))['totals']['percent_covered_display'])")
if [[ $COVERAGE_TOTAL < ${{ env.COVERAGE_TOTAL }} ]]; then
echo "FAIL Recommended total test coverage of ${{ env.COVERAGE_TOTAL }}% not reached. Total coverage: $COVERAGE_TOTAL%"
# exit 1
exit 1
fi
4 changes: 2 additions & 2 deletions requirements-base.txt
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ frozenlist==1.4.1
# aiosignal
google-api-core==2.15.0
# via google-api-python-client
google-api-python-client==2.123.0
google-api-python-client==2.124.0
# via -r requirements-base.in
google-auth==2.26.1
# via
Expand Down Expand Up @@ -376,7 +376,7 @@ scipy==1.11.4
# via statsmodels
sentry-asgi==0.2.0
# via -r requirements-base.in
sentry-sdk==1.43.0
sentry-sdk==1.44.0
# via
# -r requirements-base.in
# sentry-asgi
Expand Down
2 changes: 1 addition & 1 deletion src/dispatch/participant/flows.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def add_participant(
event_service.log_case_event(
db_session=db_session,
source="Dispatch Core App",
description=f"{individual.name} added to incident with {participant_role.role} role",
description=f"{individual.name} added to case with {participant_role.role} role",
case_id=subject.id,
)
if subject_type == "incident":
Expand Down
2 changes: 2 additions & 0 deletions src/dispatch/plugins/dispatch_slack/case/interactive.py
Original file line number Diff line number Diff line change
Expand Up @@ -837,6 +837,8 @@ def handle_case_participant_role_activity(
previous_status=case.status,
organization_slug=context["subject"].organization_slug,
)
case.status = CaseStatus.triage
db_session.commit()

case_flows.update_conversation(case, db_session)

Expand Down
128 changes: 64 additions & 64 deletions src/dispatch/static/dispatch/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a516b50

Please sign in to comment.