Skip to content

Commit

Permalink
Revert "Making experience textbox from oncall end-of-shift feedback o…
Browse files Browse the repository at this point in the history
…ptional (#3799)"

This reverts commit db544b0.
  • Loading branch information
whitdog47 authored Sep 28, 2023
1 parent c2ff65b commit 9108185
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/dispatch/plugins/dispatch_slack/feedback/interactive.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ def oncall_shift_feedback_input(
initial_value=initial_value,
multiline=True,
placeholder="How would you describe your experience?",
optional=True,
),
label=label,
**kwargs,
Expand Down Expand Up @@ -382,7 +381,7 @@ def handle_oncall_shift_feedback_submission_event(

ack_oncall_shift_feedback_submission_event(ack=ack)

feedback = form_data.get(ServiceFeedbackNotificationBlockIds.feedback_input, "")
feedback = form_data.get(ServiceFeedbackNotificationBlockIds.feedback_input)
rating = form_data.get(ServiceFeedbackNotificationBlockIds.rating_select, {}).get("value")

# metadata is organization_slug|project_id|schedule_id|shift_end_at|reminder_id
Expand Down

0 comments on commit 9108185

Please sign in to comment.