Fixes an issue with marking storage readonly when there is none (#1816)

Netflix · Nov 16, 2021 · 7018f31 · 7018f31
1 parent 54b5e25
commit 7018f31
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/dispatch/incident/flows.py b/src/dispatch/incident/flows.py
@@ -959,9 +959,9 @@ def incident_closed_status_flow(incident: Incident, db_session=None):
                 # typically only broad access to the incident document itself is required.
                 storage_plugin.instance.open(incident.incident_document.resource_id)
 
-    if storage_plugin.configuration.read_only:
-        # unfortunately this can't be applied at the folder level so we just mark the incident doc as available.
-        storage_plugin.instance.mark_readonly(incident.incident_document.resource_id)
+            if storage_plugin.configuration.read_only:
+                # unfortunately this can't be applied at the folder level so we just mark the incident doc as available.
+                storage_plugin.instance.mark_readonly(incident.incident_document.resource_id)
 
     # we send a direct message to the incident commander asking to review
     # the incident's information and to tag the incident if appropiate