Add serializeCompact to GraphQLQueryRequest #537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
While upgrading from
graphql-dgs-codegen-client-core
tographql-dgs-codegen-shared-core
, we encountered some issue because the wayGraphQLQueryRequest
is serialized is slightly different. This PR allowsGraphQLQueryRequest
to be serialized as compact which is a little bit closer to what we had before. It's IMO a little better when we want to log the query, it stays on one line.Implementation
To keep backward compatibility with Java, I created a new method. If backward compatibility with java is not an issue, I could just do one method with a default param, something like:
Testing
I feel like the unit test I added is enough, but let me know if you disagree with that, I can add more tests.