Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated JavaPluginConvention #316

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace deprecated JavaPluginConvention #316

wants to merge 2 commits into from

Conversation

paulbakker
Copy link
Collaborator

I noticed the deprecation warning from gradle. JavaPluginConvention will be removed in 8.

@paulbakker
Copy link
Collaborator Author

Turns out this doesn't work with older Gradle versions.
image

Maybe we should wait until Gradle 8 is released, which would be a good moment to drop support for older versions.

@berngp
Copy link
Contributor

berngp commented Jul 8, 2022 •
edited
Loading

Thanks @paulbakker, I just rebased with latest master. To your original point, we might have to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berngp berngp berngp approved these changes

@srinivasankavitha srinivasankavitha Awaiting requested review from srinivasankavitha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbakker @berngp