Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icon): support customIcon #122

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kiner-tang
Copy link
Collaborator

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) fix #{issue id}
  • 新功能(Feature) resolve #{issue id}
  • 代码重构(Refactor)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 类型描述更新(TypeScript definition update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 未涉及平台修改
  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

@kiner-tang kiner-tang added the enhancement New feature or request label Dec 24, 2022
@kiner-tang kiner-tang self-assigned this Dec 24, 2022
@auto-assign auto-assign bot requested a review from onlychild December 24, 2022 08:38
@changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2022

🦋 Changeset detected

Latest commit: 4717b28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
ossaui Patch
ossa-demo Patch
ossa-doc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ossa-demo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 27, 2022 at 8:22AM (UTC)
ossa-doc ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 27, 2022 at 8:22AM (UTC)

@kiner-tang
Copy link
Collaborator Author

@CaedmonW 这个pr帮忙review一下

@CaedmonW
Copy link
Collaborator

CaedmonW commented Jan 3, 2023

目前Icon组件占用的体积较大,对小程序这种有包体积限制的场景不太友好,我在想是不是把Icon组件独立出去,用户真正需要使用Icon时再按需引入Icon,而不是引入所有Icon

@kiner-tang
Copy link
Collaborator Author

目前Icon组件占用的体积较大,对小程序这种有包体积限制的场景不太友好,我在想是不是把Icon组件独立出去,用户真正需要使用Icon时再按需引入Icon,而不是引入所有Icon

确实是这样,我觉得是不是可以参考AntDesignIcon的设计:https://ant.design/components/icon-cn

@CaedmonW
Copy link
Collaborator

CaedmonW commented Jan 3, 2023

确实是这样,我觉得是不是可以参考AntDesignIcon的设计:https://ant.design/components/icon-cn

我觉得可以,我也比较过目前主流组件库的Icon设计,感觉这种确实更适合极致追求包体积的场景。不过我还没仔细评估采用这种方式对之前的组件影响。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants