Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDEV-98931] Avoid interactive constants (exit) from site module #614

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

ilia1243
Copy link
Contributor

@ilia1243 ilia1243 commented Mar 1, 2024

Description

  • kubemarine migrate_kubemarine fails with NameError: name 'exit' is not defined if run as executable file.

Fixes #612

Solution

Test Cases

TestCase 1

Steps:

  1. Run kubemarine migrate_kubemarine --list using Kubemarine v0.27.0 executable.

Results:

Before After
NameError: name 'exit' is not defined Prints "No patches available."

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@ilia1243 ilia1243 added the bug Something isn't working label Mar 1, 2024
@ilia1243 ilia1243 force-pushed the bugfix/avoid_site_interactive_constants branch from cda2dc2 to abf322e Compare March 1, 2024 14:00
@koryaga koryaga merged commit fb0916d into main Mar 4, 2024
42 checks passed
@koryaga koryaga deleted the bugfix/avoid_site_interactive_constants branch March 4, 2024 12:51
ilia1243 added a commit that referenced this pull request Mar 5, 2024
@vlar0816 vlar0816 changed the title Avoid interactive constants (exit) from site module [CPDEV-98931] Avoid interactive constants (exit) from site module Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate_kubemarine procedure fires exception
2 participants