Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GetComponentsParams "ProviderType" from "provider" to "type" #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcarbonneaux
Copy link

@mcarbonneaux mcarbonneaux commented Dec 3, 2024

This PR is to correct the issue #492 i've changed GetComponentsParams ProviderType from "provider" to "type".

cf: https://www.keycloak.org/docs-api/latest/rest-api/index.html#_component
image

i've not changed the attrribute name "ProviderType" just the params name ("type" in place of "provider") to avoid changing the rest of the code.

gocloak/models.go

Lines 305 to 310 in 77d3ec8

// GetComponentsParams represents the optional parameters for getting components
type GetComponentsParams struct {
Name *string `json:"name,omitempty"`
ProviderType *string `json:"provider,omitempty"`
ParentID *string `json:"parent,omitempty"`
}

@mcarbonneaux mcarbonneaux changed the title Change GetComponentsParams ProviderType from "provider" to "type" Change GetComponentsParams "ProviderType" from "provider" to "type" Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant