Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Fidelity Accounts that Start with "Y" #397

Merged
merged 9 commits into from
Oct 8, 2024
Merged

Conversation

NelsonDane
Copy link
Owner

Fidelity accounts that start with a Y are Fidelity-managed accounts and not available for manual trading. These should be skipped with this PR.

@NelsonDane NelsonDane requested a review from matthew55 October 8, 2024 13:01
@fogoat
Copy link
Contributor

fogoat commented Oct 8, 2024

@matthew55 a manual exclusion list in .env would be better for me. block certain account numbers which means we don't have to make any changes in terms of account number exclusions in the future. If Fidelity every changes their naming scheme, blocking with a prefix of Y could mean changes are necessary in the future and doesn't necessarily exclude other accounts. We have crypto, charity, employer accts, etc that all could have their own naming scheme which blocking Y would do nothing for.

@matthew55
Copy link
Contributor

@matthew55 a manual exclusion list in .env would be better for me. block certain account numbers which means we don't have to make any changes in terms of account number exclusions in the future. If Fidelity every changes their naming scheme, blocking with a prefix of Y could mean changes are necessary in the future and doesn't necessarily exclude other accounts. We have crypto, charity, employer accts, etc that all could have their own naming scheme which blocking Y would do nothing for.

It would be nice, but that is too much work for now. This will work until then.

@matthew55 matthew55 merged commit b9365a9 into main Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants