Fixes for compilation on Ubuntu 20.10 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See open-mpi/ompi#5157 (comment) for an explanation of this "hack that you can do that's gross but safe". I agree that it's gross but they've at least got their workaround macro nicely namespaced so it shouldn't interact with other code or other MPI implementations. Without some workaround, including OpenMPI's mpi.h in C++ code is a compiler warning on many compilers and a compiler *error* on others, including the last couple g++ releases. I can't build the nekRS fork of occa without this.
It's been deprecated for a while, and at least on Ubuntu 20.10 it no longer exists at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenMPI mpicxx workaround is the same as in Nek5000/nekRS@878b9ab
It looks like my commits from Nek5000/nekRS#235 are being incorporated into Nek5000/nekRS#231 ? This might be worth bringing into that too, then.