Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply breduce to reduce snapshot projection time #217

Merged
merged 40 commits into from
Apr 5, 2024
Merged

Conversation

kent0
Copy link
Collaborator

@kent0 kent0 commented Mar 26, 2024

implemented uip (universal inner-product) to replace pv2k and ps2k with p2k. uip will be used to replace various inner-products subroutines to simplify and in the future will be used to form the Gramian and the operators.

@Ping-Hsuan
Copy link
Collaborator

@kent0, can you explain to me why changing from lsu to lsu+1? Was the allocation for those variables are not correct? Or it is just for consistency? Thanks!

@kent0
Copy link
Collaborator Author

kent0 commented Mar 29, 2024

@Ping-Hsuan, I still need to modify the breduce subroutine so please wait for that commit before merging.

@kent0
Copy link
Collaborator Author

kent0 commented Apr 1, 2024

@Ping-Hsuan, this PR is good from my side (I think the load balancing modification is unnecessary) so please merge if after review.

@Ping-Hsuan Ping-Hsuan merged commit d40f311 into master Apr 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants