Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cssClickableGallery/ #11

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Adds cssClickableGallery/ #11

merged 3 commits into from
Oct 14, 2019

Conversation

subhamX
Copy link
Contributor

@subhamX subhamX commented Oct 8, 2019

Solves issue #8 [3]

Copy link
Owner

@Neha Neha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I am going on smaller resolution from desktop to tab. The 1 card is coming in 2nd row and in centre. Which should not be the case. Can we fix this issue?

https://stackoverflow.com/questions/32802202/how-to-center-a-flex-container-but-left-align-flex-items

Fixes the left alignment issue of the last child
@subhamX
Copy link
Contributor Author

subhamX commented Oct 10, 2019

@Neha, I have fixed the issue with CSS Grid. Please have a look at it. 😀

@subhamX subhamX requested a review from Neha October 10, 2019 04:00
Syncing the repo with Neha/css3-demos/master[upstream]
@subhamX
Copy link
Contributor Author

subhamX commented Oct 11, 2019

@Neha Maam. Please have a look and tell me where should I make changes.

Copy link
Owner

@Neha Neha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this.

All looks good...approving it!!

@Neha Neha merged commit 4b5b150 into Neha:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants