Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the code example of the images gallery (4 developers can contribute to it) #8

Open
Neha opened this issue Oct 8, 2019 · 15 comments
Assignees

Comments

@Neha
Copy link
Owner

Neha commented Oct 8, 2019

Develop the HTML and CSS based image gallery. Do not use Floats or positions. You can use only flex or grids only.

We will have 4 types of Gallery:

  1. Gallery displaying only images thumbnails - @rzdev is working on it.
  2. Gallery with image and the caption or title over image thumbnail - @joshuafbarker worked on it and it is merged too.
  3. Gallery with clickable thumbnail - @shubhamx is working on it
  4. Gallery with image, caption/title, description text and clickable. - @imrishabh18 is working on it.

The gallery should be accessible and responsive. On desktop the grid should be of 4X4 , on tab 3X3 and on mobile 2X2.

The gallery version # 3 and # 4 should have hover effect.

@rzadev
Copy link
Contributor

rzadev commented Oct 8, 2019

Hi Neha, I can help you to create gallery type 1.

@Neha
Copy link
Owner Author

Neha commented Oct 8, 2019

@rzadev awesome assigning to you.

@subhamX
Copy link
Contributor

subhamX commented Oct 8, 2019

I would like to work on this. [Type 1]

@Neha
Copy link
Owner Author

Neha commented Oct 8, 2019

@subhamX , # 1 is already assigned to @rzadev .

Would you like to go with # 2?

@subhamX
Copy link
Contributor

subhamX commented Oct 8, 2019

3 would be better. 🙂

@rzadev
Copy link
Contributor

rzadev commented Oct 8, 2019

@rzadev awesome assigning to you.

@Neha great, I'm working on it.

@joshuafbarker
Copy link
Contributor

I will develop #2

@imrishabh18
Copy link

I would like to work on [2].

@Neha
Copy link
Owner Author

Neha commented Oct 9, 2019

@imrishabh18 # 2 is taken by @joshuafbarker . Only # 4 is left. Would you like to go for that?

@imrishabh18
Copy link

@Neha Okay l will try.

@Neha
Copy link
Owner Author

Neha commented Oct 9, 2019

Hello All,

I just merged the PR by @joshuafbarker. You all can have a look to that as base code.

Thanks,
Neha

PraveenPal4232 added a commit to PraveenPal4232/css3-demos that referenced this issue Oct 9, 2019
@rzadev
Copy link
Contributor

rzadev commented Oct 9, 2019

Hello All,

I just merged the PR by @joshuafbarker. You all can have a look to that as base code.

Thanks,
Neha

@Neha Ok, noted.

@rzadev
Copy link
Contributor

rzadev commented Oct 14, 2019

Hello @Neha, I have submitted my pull request four days ago but you haven't merged it yet, is there any issue?

@Neha
Copy link
Owner Author

Neha commented Oct 14, 2019

Hello @rzadev , I didn't got the time to review. Just reviewed and merged too.

@rzadev
Copy link
Contributor

rzadev commented Oct 14, 2019

Ok, thank you @Neha.

@imrishabh18 imrishabh18 removed their assignment Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants