Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return :ok even if nothing is logged #126

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Always return :ok even if nothing is logged #126

merged 2 commits into from
Aug 6, 2024

Conversation

adamu
Copy link
Contributor

@adamu adamu commented Jul 31, 2024

Make the return type of telemetry_logging_handler conform to its spec.

Currently, if the if level = level(level, conn) condition fails, the function returns nil, not :ok as specified.

@AndrewDryga
Copy link
Member

@adamu thank you! Can you please add a test to make sure this case is covered too? Other than that LGTM.

@coveralls
Copy link

coveralls commented Jul 31, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling b6a31b8 on adamu:ok
into cad5979 on Nebo15:master.

@adamu
Copy link
Contributor Author

adamu commented Aug 3, 2024

@AndrewDryga added!

@AndrewDryga AndrewDryga merged commit 2e72e28 into Nebo15:master Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants