fix: clarify default logging

By default it will log Operations,
except when in CI or in AppEngine.

src/adapter/cachedb/cache.db.model.ts

@@ -40,10 +40,7 @@ export interface CacheDBCfg {
   logDownstream?: boolean
 
   /**
-   * Pass noopLogger (or undefined) to skip logging completely.
-   *
-   * Defaults to `console` in dev.
-   * Default to noop in AppEngine.
+   * Defaults to `console`.
    */
   logger?: CommonLogger
 }

src/adapter/cachedb/cache.db.ts

@@ -16,8 +16,6 @@ import {
   CacheDBStreamOptions,
 } from './cache.db.model'
 
-const isGAE = !!process.env['GAE_INSTANCE']
-
 /**
  * CommonDB implementation that proxies requests to downstream CommonDB
  * and does in-memory caching.
@@ -28,7 +26,7 @@ export class CacheDB extends BaseCommonDB implements CommonDB {
   constructor(cfg: CacheDBCfg) {
     super()
     this.cfg = {
-      logger: isGAE ? undefined : console,
+      logger: console,
       ...cfg,
     }
   }

src/adapter/file/file.db.model.ts

@@ -24,8 +24,7 @@ export interface FileDBCfg {
   sortObjects?: boolean
 
   /**
-   * Defaults to `console` in dev.
-   * Default to noop in AppEngine.
+   * Defaults to `console`.
    */
   logger?: CommonLogger
 

src/adapter/file/file.db.ts

@@ -28,8 +28,6 @@ import { DBQuery } from '../../query/dbQuery'
 import { DBTransaction } from '../../transaction/dbTransaction'
 import { FileDBCfg } from './file.db.model'
 
-const isGAE = !!process.env['GAE_INSTANCE']
-
 /**
  * Provides barebone implementation for "whole file" based CommonDB.
  * "whole file" means that the persistence layer doesn't allow any querying,
@@ -46,7 +44,7 @@ export class FileDB extends BaseCommonDB implements CommonDB {
     this.cfg = {
       sortObjects: true,
       logFinished: true,
-      logger: isGAE ? undefined : console,
+      logger: console,
       ...cfg,
     }
   }

src/adapter/inmemory/inMemory.db.ts

@@ -65,14 +65,11 @@ export interface InMemoryDBCfg {
   persistZip: boolean
 
   /**
-   * Defaults to `console` in dev.
-   * Default to noop in AppEngine.
+   * Defaults to `console`.
    */
   logger?: CommonLogger
 }
 
-const isGAE = !!process.env['GAE_INSTANCE']
-
 export class InMemoryDB implements CommonDB {
   constructor(cfg?: Partial<InMemoryDBCfg>) {
     this.cfg = {
@@ -81,7 +78,7 @@ export class InMemoryDB implements CommonDB {
       persistenceEnabled: false,
       persistZip: true,
       persistentStoragePath: './tmp/inmemorydb',
-      logger: isGAE ? undefined : console,
+      logger: console,
       ...cfg,
     }
   }

src/commondao/common.dao.model.ts

@@ -46,8 +46,17 @@ export enum CommonDaoLogLevel {
    * Same as undefined
    */
   NONE = 0,
+  /**
+   * Log operations (e.g "getById returned 1 row"), but not data
+   */
   OPERATIONS = 10,
+  /**
+   * Log operations and data for single operations (e.g getById), but not batch operations.
+   */
   DATA_SINGLE = 20,
+  /**
+   * Log EVERYTHING - all data passing in and out (max 10 rows). Very verbose!
+   */
   DATA_FULL = 30,
 }
 
@@ -71,10 +80,7 @@ export interface CommonDaoCfg<BM extends Partial<ObjectWithId>, DBM extends Obje
   readOnly?: boolean
 
   /**
-   * Pass undefined (or noopLogger) to disable logging completely.
-   *
-   * Defaults to `console` in dev.
-   * Default to noop in AppEngine.
+   * Defaults to `console`
    */
   logger?: CommonLogger
 

src/commondao/common.dao.ts

@@ -1,35 +1,35 @@
 import {
+  _filterNullishValues,
+  _filterUndefinedValues,
+  _passthroughPredicate,
+  _since,
+  _truncate,
+  _uniqBy,
   AppError,
   AsyncMapper,
   ErrorMode,
   JsonSchemaObject,
-  _passthroughPredicate,
-  _since,
-  _truncate,
-  pMap,
   JsonSchemaRootObject,
-  Saved,
-  _uniqBy,
   ObjectWithId,
-  _filterUndefinedValues,
-  _filterNullishValues,
+  pMap,
+  Saved,
 } from '@naturalcycles/js-lib'
 import {
+  _pipeline,
   AjvSchema,
   AjvValidationError,
   getValidationResult,
   JoiValidationError,
   ObjectSchemaTyped,
   ReadableTyped,
   stringId,
+  transformBuffer,
   transformLogProgress,
   transformMap,
   transformMapSimple,
   transformMapSync,
   transformTap,
   writableVoid,
-  _pipeline,
-  transformBuffer,
 } from '@naturalcycles/nodejs-lib'
 import { DBLibError } from '../cnst'
 import { DBModelType, RunQueryResult } from '../db.model'
@@ -47,6 +47,7 @@ import {
 /* eslint-disable no-dupe-class-members */
 
 const isGAE = !!process.env['GAE_INSTANCE']
+const isCI = !!process.env['CI']
 
 /**
  * Lowest common denominator API between supported Databases.
@@ -62,9 +63,12 @@ export class CommonDao<
 > {
   constructor(public cfg: CommonDaoCfg<BM, DBM, TM>) {
     this.cfg = {
-      logLevel: CommonDaoLogLevel.OPERATIONS,
+      // Default is to NOT log in AppEngine and in CI,
+      // otherwise to log Operations
+      // e.g in Dev (local machine), Test - it will log operations (useful for debugging)
+      logLevel: isGAE || isCI ? CommonDaoLogLevel.NONE : CommonDaoLogLevel.OPERATIONS,
       createdUpdated: true,
-      logger: isGAE ? undefined : console,
+      logger: console,
       ...cfg,
       hooks: {
         createId: () => stringId(),
@@ -979,8 +983,6 @@ export class CommonDao<
     await this.cfg.db.ping()
   }
 
-  // todo: logging
-  // todo: bmToDBM, etc. How?
   // transaction(): DBTransaction {
   //   return this.cfg.db.transaction()
   // }
@@ -994,7 +996,7 @@ export class CommonDao<
     if (Array.isArray(res)) {
       logRes = `${res.length} row(s)`
       if (res.length && this.cfg.logLevel >= CommonDaoLogLevel.DATA_FULL) {
-        args.push('\n', res.slice(0, 10)) // max 10 items
+        args.push('\n', ...res.slice(0, 10)) // max 10 items
       }
     } else if (res) {
       logRes = `1 row`
@@ -1005,7 +1007,7 @@ export class CommonDao<
       logRes = `undefined`
     }
 
-    this.cfg.logger?.log(...[`<< ${table}.${op}: ${logRes} in ${_since(started)}`].concat(args))
+    this.cfg.logger?.log(`<< ${table}.${op}: ${logRes} in ${_since(started)}`, ...args)
   }
 
   protected logSaveResult(started: number, op: string, table: string): void {