-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/google-map-utils #298
base: main
Are you sure you want to change the base?
feat/google-map-utils #298
Conversation
* fixes android ground overlay from position * adds ground overlay from bounds * fixes map style
@triniwiz @NathanWalker Hopefully I can come back to this soon but at the moment my time is becoming pretty limited. Might be worth pushing these feaures as a baseline till I get a chance to come back to this. Thoughts? |
@herefishyfish thank you, If you don't mind I can finish it up. 😄 |
@triniwiz I don't mind. I did however notice that the iOS util tooling doesn't actually support the Icon generator for custom icons that android has available - so that makes this a bit easier again :) |
I'm very interested in the clustering feature, I tried implementing it myself on the old dapriett/nativescript-google-maps-sdk plugin but failed when it came to info windows and custom markers. @herefishyfish since it seems you have better understanding of this, do you think it's possible to implement clustering with custom marker icons (static resources, not clusters) and info windows? By this I mean, do both Android and iOS support this feature? |
Both iOS and Android suppport custom cluster icons for sure. Not so sure about cluster info windows though.
Android you can extend the custom renderer I've created here or create your own and override the render function like so:
|
I love this PR, I was looking for how to do clustering. Why is this PR not divided into smaller PRs? so we can have features faster and not have to wait for everything to be ready |
@herefishyfish if everything checked off list looks good on your end we could publish a minor version bump with this and handle KML in separate PR, lemme know your thoughts? |
@NathanWalker Heatmaps and clustering are in a pretty good state. GeoJson will most likely get refactored with the KML implementation. I think there are a couple of stylistic differences between @triniwiz google-maps and how I have implemented the features and would like to get his aproval over anything else before we commit this PR. However I am perfectly okay with handling the KML/GeoJson part in a seperate PR and think we can push this for sure. |
Hi, has @triniwiz expressed his approval? |
@tommag21 I'll wrap this up soon, sorry some other things came up. |
…ish/nativescript-plugins into feat/google-map-utils
Google map utilities library integration.
Features: