Add search functionality and other QOL changes to Edge Dictionary page #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are before / after visuals of the Edge Dictionary page: Before After |
alerman
reviewed
Jan 9, 2025
| @@ -8,7 +8,7 @@ | |||
| <relativePath>../../../microservice-parent/pom.xml</relativePath> | |||
| </parent> | |||
| <artifactId>dictionary-api</artifactId> | |||
| <version>4.0.5-SNAPSHOT</version> | |||
| <version>4.0.5</version> | |||
There was a problem hiding this comment.
Has 4.0.5, been released? Typically we would change this to do the release then set it to the next snapshot.
There was a problem hiding this comment.
I will fix this up when merging it in.
ivakegg
reviewed
Jan 29, 2025
| @@ -41,9 +48,12 @@ public class DefaultEdgeDictionary extends EdgeDictionaryBase<DefaultEdgeDiction | |||
| @XmlElement(name = "TotalResults") | |||
| private Long totalResults = null; | |||
|
|
|||
| public DefaultEdgeDictionary() {} | |||
| public DefaultEdgeDictionary() { | |||
| this.jqueryUri = "/dictionary/webjars/jquery/"; | |||
There was a problem hiding this comment.
Can I presume these two endpoints are available in the dictionary service?
There was a problem hiding this comment.
@ivakegg They are, however, the dictionary K8s/pod container needs to be running for these endpoints to work.
ivakegg
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following to the Edge Dictionary page:
Closes #35