fix(stark-ui): generic-search trigger search on enter #3459

mhenkens · 2022-09-14T13:40:13Z

When press Enter key now the search is trigger

ISSUES CLOSED: #3116

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#-commit-message-guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3116

What is the new behavior?

When press the Enter key, the form is sbmitted.

Does this PR introduce a breaking change?

[X] Yes
[] No

The search form search component should implement the new property submitEvent.

In the component template add (ngSubmit)="submitEvent.next()" attribute to the <form>

inside the <form> add
<button [hidden]="true" type="submit"></button>

see the showcase adaptation

Other information

coveralls · 2022-09-14T13:49:43Z

Coverage decreased (-0.04%) to 88.125% when pulling 16f85f6 on mhenkens:bugfix/3116 into cece193 on NationalBankBelgium:master.

When press Enter key now the search is trigger Braking Change: The Components implementing `StarkSearchFormComponent` must implement `submitEvent` In the component template in the <form > tag `(ngSubmit)="submitEvent.next()" and add `<button [hidden]="true" type="submit"></button>` ISSUES CLOSED: NationalBankBelgium#3116