Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-ui): session - prevent click outside the Session Timeout Warning Dialog #1605

Conversation

SuperITMan
Copy link
Member

@SuperITMan SuperITMan commented Feb 3, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

When the Session Timeout Warning Dialog appears, clicking outside the dialog hides the dialog but does not stop the countdown. So the user is disconnected automatically at the end of the countdown.

Issue Number: #1561

What is the new behavior?

Clicking outside of the dialog does not do anything. Like this, the user cannot close the dialog due to a wrong manipulation.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link
Collaborator

@christophercr christophercr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good, however the unit test should be adapted... cause right now it is failing:

Effects: StarkSessionTimeoutWarningDialogEffects
    On StarkSessionTimeoutWarning$
      ✖ Should open a dialog when the timeout countdown begins

@SuperITMan SuperITMan force-pushed the bugfix/stark-ui-session-timeout-warning-dialog-click-escape branch from d916761 to 8283216 Compare February 3, 2020 13:44
Copy link
Collaborator

@christophercr christophercr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.116% when pulling 8283216 on SuperITMan:bugfix/stark-ui-session-timeout-warning-dialog-click-escape into 4fad147 on NationalBankBelgium:master.

Copy link
Contributor

@nicanac nicanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants