Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: the big bump #433

Merged
merged 18 commits into from
Jan 14, 2025
Merged

Chore: the big bump #433

merged 18 commits into from
Jan 14, 2025

Conversation

nnansters
Copy link
Contributor

This is the one: the big dependency bump!

As Python 3.8 is end-of-life, this release drops the support for it. This allows us to bump a lot of our core dependencies:

numpy = "^2.0"

scipy = "^1.13"

pandas = "^2.2"

scikit-learn = "^1.6"

pyarrow = "^18.1"

This should be a lot less restrictive for people with up-to-date installations.
Working with these versions means we now support Python 3.12 as well!

@nnansters nnansters force-pushed the chore/update-dependencies branch from 3e0baa4 to cc51010 Compare December 18, 2024 18:26
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 40.05236% with 229 lines in your changes missing coverage. Please review.

Project coverage is 74.68%. Comparing base (c6d326e) to head (ded92d2).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...performance_estimation/confidence_based/metrics.py 29.72% 104 Missing ⚠️
...e_calculation/metrics/multiclass_classification.py 2.85% 34 Missing ⚠️
...nyml/performance_calculation/metrics/regression.py 56.36% 24 Missing ⚠️
...mance_estimation/direct_loss_estimation/metrics.py 65.07% 22 Missing ⚠️
...mance_calculation/metrics/binary_classification.py 53.33% 21 Missing ⚠️
...rformance_estimation/direct_loss_estimation/dle.py 0.00% 6 Missing ⚠️
nannyml/stats/avg/calculator.py 0.00% 4 Missing ⚠️
nannyml/stats/median/calculator.py 0.00% 4 Missing ⚠️
nannyml/stats/std/calculator.py 0.00% 4 Missing ⚠️
nannyml/stats/sum/calculator.py 0.00% 4 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   74.77%   74.68%   -0.09%     
==========================================
  Files         109      109              
  Lines        9703     9726      +23     
  Branches     1537     1183     -354     
==========================================
+ Hits         7255     7264       +9     
- Misses       1966     1981      +15     
+ Partials      482      481       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters nnansters marked this pull request as ready for review December 19, 2024 12:14
@nnansters nnansters requested a review from nikml as a code owner December 19, 2024 12:14
@nnansters
Copy link
Contributor Author

Finally got round to it. Take a peek at the dependencies in pyproject.toml and see if it covers your needs!

#431
#430
#428
#427
#424

This was referenced Dec 19, 2024
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@davisthomas-aily
Copy link

Great work! Always nice to see that the package is being maintained.
I've left some comments-I think the pyproject might benefit from a little division of dependencies into main and dev (and additional ones if you really want to clean house) - this keeps it from being too restrictive, as users importing this into their own env will never actually need to actively modify the library.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@canoadri
Copy link

canoadri commented Jan 2, 2025

Hi all, any updates on this PR?

@nnansters
Copy link
Contributor Author

Hey all, thanks for the feedback and suggestions (special shout-out to @davisthomas-aily ).

I've been testing and tweaking some stuff so the following (primary) dependencies are now:

numpy = "^2.0" -> numpy = ">=1.23"

scipy = "^1.13" -> scipy = ">=1.9.2"

pandas = "^2.2" -> pandas = ">=1.4"

scikit-learn = "^1.6" -> scikit-learn = ">=1.3"

pyarrow = "^18.1" -> pyarrow = ">=13.0"

As you can see, this should give a lot more freedom to the end user, offering a whole range of versions to use. I've based myself on the scientific Python SPEC0 to determine the range of versions. Python 3.9 is also still supported.

What do you think?

pyproject.toml Outdated Show resolved Hide resolved
Copy link

@davisthomas-aily davisthomas-aily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ❤️

@canoadri
Copy link

Hi @nnansters, do we have an ETA on closing this? 🙏

@nnansters
Copy link
Contributor Author

Hi @nnansters, do we have an ETA on closing this? 🙏

Wanted to give all a chance to chime in, I suppose that's done now!

Will merge now, will try to squeeze in a release tonight!

@nnansters nnansters merged commit ba5d263 into main Jan 14, 2025
4 of 7 checks passed
@davisthomas-aily
Copy link

Quick reminder, I think you might need to bump the version in the pyproject

@nnansters
Copy link
Contributor Author

@davisthomas-aily yup, that's part of the release process!

@davisthomas-aily
Copy link

Bad news, I think we missed one 🙃 - #436
Can we add this to this release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants