-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: the big bump #433
Chore: the big bump #433
Conversation
Rewrote the logic that performs value counting to simplify grouping behavior.
…` after the `squared` parameter was removed.
…at all big compute libraries were majorly bumped.
3e0baa4
to
cc51010
Compare
…calculation methods. Direct consequence of numpy/numpy@c63969c
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 74.77% 74.68% -0.09%
==========================================
Files 109 109
Lines 9703 9726 +23
Branches 1537 1183 -354
==========================================
+ Hits 7255 7264 +9
- Misses 1966 1981 +15
+ Partials 482 481 -1 ☔ View full report in Codecov by Sentry. |
Great work! Always nice to see that the package is being maintained. |
Hi all, any updates on this PR? |
Hey all, thanks for the feedback and suggestions (special shout-out to @davisthomas-aily ). I've been testing and tweaking some stuff so the following (primary) dependencies are now:
As you can see, this should give a lot more freedom to the end user, offering a whole range of versions to use. I've based myself on the scientific Python SPEC0 to determine the range of versions. Python 3.9 is also still supported. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! ❤️
Hi @nnansters, do we have an ETA on closing this? 🙏 |
Wanted to give all a chance to chime in, I suppose that's done now! Will merge now, will try to squeeze in a release tonight! |
Quick reminder, I think you might need to bump the version in the pyproject |
@davisthomas-aily yup, that's part of the release process! |
Bad news, I think we missed one 🙃 - #436 |
This is the one: the big dependency bump!
As Python 3.8 is end-of-life, this release drops the support for it. This allows us to bump a lot of our core dependencies:
This should be a lot less restrictive for people with up-to-date installations.
Working with these versions means we now support Python 3.12 as well!