Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sqlite bundle system in windows #879

Merged
merged 4 commits into from
Jun 29, 2024

Conversation

bigfoodK
Copy link
Contributor

@bigfoodK bigfoodK commented Jun 29, 2024

Closes #878

Tested with my local and image-load-background sample.

@bigfoodK bigfoodK added enhancement New feature or request namui This issue is for namui engine labels Jun 29, 2024
@bigfoodK bigfoodK requested a review from namse June 29, 2024 02:12
@bigfoodK bigfoodK self-assigned this Jun 29, 2024
@bigfoodK bigfoodK merged commit 474dfce into namui/bundle-sqlite2 Jun 29, 2024
7 of 29 checks passed
@bigfoodK bigfoodK deleted the namui/bundle-sqllite2-windows branch June 29, 2024 02:14
bigfoodK added a commit that referenced this pull request Jun 29, 2024
@namse
Copy link
Contributor

namse commented Jun 29, 2024

If you want review, don't merge without review.

@bigfoodK
Copy link
Contributor Author

I thought I activated auto-merge

@namse
Copy link
Contributor

namse commented Jun 30, 2024

Yes you activated auto merge, and that only works on master branch.
image

You want that rule also works for other branches?

namse added a commit that referenced this pull request Jul 1, 2024
Update Cargo.lock

Rollback env

Chore

'bundle:...' to '...'

Support sqlite bundle system in windows (#879)

Update thread-worker.ts

Update thread-worker.ts

Revert "Remove query in sqlite path for windows"

This reverts commit 559b743.

Follow sqlite filepath-uri conversion instructions

Remove log

Update namui/namui-cli/src/services/resource_collect_service.rs

Co-authored-by: Nam Se Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request namui This issue is for namui engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants