Remove cluster connection override (#40)

* Remove cluster connection override to use default cluster connector from phpredis * Remove obsolete NotImplementedException --------- Co-authored-by: Alhubing <> Co-authored-by: Marvin Mall <[email protected]>
Namoshek · Nov 6, 2024 · f9427bd · f9427bd
1 parent d4742bd
commit f9427bd
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 34 deletions.
diff --git a/src/Connectors/PhpRedisSentinelConnector.php b/src/Connectors/PhpRedisSentinelConnector.php
@@ -8,7 +8,6 @@
 use Illuminate\Support\Arr;
 use Namoshek\Redis\Sentinel\Connections\PhpRedisSentinelConnection;
 use Namoshek\Redis\Sentinel\Exceptions\ConfigurationException;
-use Namoshek\Redis\Sentinel\Exceptions\NotImplementedException;
 use Redis;
 use RedisException;
 use RedisSentinel;
@@ -36,14 +35,6 @@ public function connect(array $config, array $options): PhpRedisSentinelConnecti
         return new PhpRedisSentinelConnection($connector(), $connector, $config);
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function connectToCluster(array $config, array $clusterOptions, array $options)
-    {
-        throw new NotImplementedException('The Redis Sentinel driver does not support connecting to clusters.');
-    }
-
     /**
      * Create the PhpRedis client instance which connects to Redis Sentinel.
      *

diff --git a/src/Exceptions/NotImplementedException.php b/src/Exceptions/NotImplementedException.php
diff --git a/tests/Connectors/PhpRedisSentinelConnectorTest.php b/tests/Connectors/PhpRedisSentinelConnectorTest.php
@@ -7,7 +7,6 @@
 use Illuminate\Redis\RedisManager;
 use Namoshek\Redis\Sentinel\Connections\PhpRedisSentinelConnection;
 use Namoshek\Redis\Sentinel\Connectors\PhpRedisSentinelConnector;
-use Namoshek\Redis\Sentinel\Exceptions\NotImplementedException;
 use Namoshek\Redis\Sentinel\Tests\TestCase;
 use Redis;
 use RedisException;
@@ -17,18 +16,6 @@
  */
 class PhpRedisSentinelConnectorTest extends TestCase
 {
-    public function test_connecting_to_cluster_is_not_possible()
-    {
-        $this->expectException(NotImplementedException::class);
-
-        $connector = new PhpRedisSentinelConnector();
-        $connector->connectToCluster(
-            config: [],
-            clusterOptions: [],
-            options: []
-        );
-    }
-
     /**
      * @throws RedisException
      */