Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme #89

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Readme #89

wants to merge 9 commits into from

Conversation

Feldmarszalekduda
Copy link
Member

@Feldmarszalekduda Feldmarszalekduda commented Feb 7, 2019

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0713483). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #89   +/-   ##
======================================
  Coverage          ?   98%           
======================================
  Files             ?    55           
  Lines             ?   851           
  Branches          ?     0           
======================================
  Hits              ?   834           
  Misses            ?    17           
  Partials          ?     0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0713483...6905690. Read the comment docs.

Copy link
Collaborator

@kn65op kn65op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Feldmarszalekduda)


README.md, line 13 at r1 (raw file):

- git
- cmake
- boost headers

I would say boost dev version.


README.md, line 14 at r1 (raw file):

- cmake
- boost headers
- sfml (we are using version 2.5)

I would say sfml dev version.


README.md, line 77 at r1 (raw file):

# 4 Running UTs

Running UTs is very simple. If You look at available targets:

Another way is to build all UT targets and run ctest.

Copy link
Member Author

@Feldmarszalekduda Feldmarszalekduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @kn65op)


README.md, line 13 at r1 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

I would say boost dev version.

Done.


README.md, line 14 at r1 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

I would say sfml dev version.

Done.


README.md, line 77 at r1 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Another way is to build all UT targets and run ctest.

Done.

Copy link
Member

@Abergard Abergard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @kn65op)

Copy link
Collaborator

@kn65op kn65op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kn65op)

Copy link
Collaborator

@kn65op kn65op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@kn65op kn65op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Feldmarszalekduda)


README.md, line 14 at r2 (raw file):

- cmake
- boost dev version
- sfml dev version (at leeast 2.5)

Typo: leeast

Copy link
Member Author

@Feldmarszalekduda Feldmarszalekduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Abergard and @kn65op)


README.md, line 14 at r2 (raw file):

Previously, kn65op (Tomasz Drzewiecki) wrote…

Typo: leeast

Done.

Copy link
Collaborator

@kn65op kn65op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@Abergard Abergard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@Abergard Abergard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@Abergard Abergard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@Abergard Abergard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@Abergard Abergard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@Abergard Abergard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@kn65op kn65op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants