-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI : add confidence to daily plot labels #223
base: main
Are you sure you want to change the base?
Conversation
In parallel I'm looking if a plotly interactive chart is feasible - although those charts are good for archiving |
Though not as pretty, I guess the two columns are more readable, yes. A couple of thoughts:
Maybe it would be better/easier to plonk the columns into the current implementation? (I might have a look myself) |
Thanks I see your point. I actually copy pasted @jmtmp's code but indeed code robustness could be better with continuity and only tweaking the current code! |
Here is a code proposal based on the current daily plot. I've taken the opportunity to solve an issue with the heatmap of the Counts column : it was using the "latest" Confidence instead of the "Max" as expected in the code, which was not apparent until they appeared side-by-side with the max confidence column. |
I thought that the new column addition didn't work easily with the current theme. The initial design with column seems cleaner to me but I understand if preference is to keep code as simple as possible in this main repo for robustness. So here is another proposal : if we don't change the main layout, we could just add the values to the current graph. Changes to overlaid labels :
|
Hi @Nachtzuster, are you interested to have this in the fork ?
@jmtmp has made new daily and yearly graphs that could be more readable with confidence in a column (thanks!)