Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI : add confidence to daily plot labels #223

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

alexbelgium
Copy link

@alexbelgium alexbelgium commented Oct 28, 2024

Hi @Nachtzuster, are you interested to have this in the fork ?

@jmtmp has made new daily and yearly graphs that could be more readable with confidence in a column (thanks!)

image

image

@alexbelgium
Copy link
Author

In parallel I'm looking if a plotly interactive chart is feasible - although those charts are good for archiving

@Nachtzuster
Copy link
Owner

Though not as pretty, I guess the two columns are more readable, yes.

A couple of thoughts:

  • BirdNET-Pi doesn't really use blue anywhere, that should turn green again
  • the graph seems to be shifted to the right somehow
  • the current implementation got a couple of fixes along the way (eg non-ascii lanuages), we don't want to re-introduce these issues

Maybe it would be better/easier to plonk the columns into the current implementation? (I might have a look myself)

@alexbelgium
Copy link
Author

Thanks I see your point. I actually copy pasted @jmtmp's code but indeed code robustness could be better with continuity and only tweaking the current code!

@alexbelgium alexbelgium marked this pull request as draft November 2, 2024 08:03
@alexbelgium
Copy link
Author

Here is a code proposal based on the current daily plot.

I've taken the opportunity to solve an issue with the heatmap of the Counts column : it was using the "latest" Confidence instead of the "Max" as expected in the code, which was not apparent until they appeared side-by-side with the max confidence column.

@alexbelgium
Copy link
Author

alexbelgium commented Nov 2, 2024

Mmh I updated but honestly it's not super pretty...

Proposed
image
Proposed
image

@alexbelgium
Copy link
Author

alexbelgium commented Nov 8, 2024

I thought that the new column addition didn't work easily with the current theme. The initial design with column seems cleaner to me but I understand if preference is to keep code as simple as possible in this main repo for robustness.

So here is another proposal : if we don't change the main layout, we could just add the values to the current graph.

Changes to overlaid labels :

  • Add minimum pad so that values don't overlap with species names for very low values
  • Add max confidence to barchart (in addition to count)
  • Change padding from 0.9x column width to 0.7x column width to account for longer label)
  • Add alpha transparency for better appearance

image

image

@alexbelgium alexbelgium changed the title UI : new daily (and yearly) plots @jmtmp UI : new daily plot with confidence Nov 8, 2024
@alexbelgium alexbelgium marked this pull request as ready for review November 8, 2024 16:17
@alexbelgium alexbelgium changed the title UI : new daily plot with confidence UI : add confidence to daily plot labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants