SFR-2416: Run e2e tests on local domain #569
Open
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackiequach
changed the title
jackiequach
requested review from
samanthaandrews and
kylevillegas93
as code owners
playwright/integration/auth.spec.ts
Outdated
| @@ -14,7 +14,7 @@ test.beforeEach(async ({ context }) => { | |||
| test.afterEach(() => server.resetHandlers()); | |||
| test.afterAll(() => server.close()); | |||
|
|
|||
| test.describe("Cookie authentication", () => { | |||
| test.skip("Cookie authentication", () => { | |||
There was a problem hiding this comment.
does this test still not pass? should we skip?
There was a problem hiding this comment.
The tests didn't pass due to a double redirect for the login.nypl.org page. I updated the tests to check for the final destination.
| @@ -15,6 +15,19 @@ jobs: | |||
| with: | |||
| node-version-file: ".nvmrc" | |||
|
|
|||
| - name: Set environment for branch | |||
| run: | | |||
| if [[ $GITHUB_REF_NAME == 'production' ]]; then | |||
There was a problem hiding this comment.
should this be [[ $GITHUB_REF_NAME == 'development' ]]?
There was a problem hiding this comment.
since we talked about getting rid of the produciton/development branches and just using main for full CI/CD i'm wondering if this makes sense to use as a check. is there another check we could use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
This PR does the following:
Testing requirements & instructions: