Merge branch 'development' into remove-survey-banner

.github/workflows/Playwright.yml

@@ -15,8 +15,21 @@ jobs:
         with:
           node-version-file: ".nvmrc"
 
+      - name: Set environment for branch
+        run: |
+          if [[ $GITHUB_REF_NAME == 'production' ]]; then
+              echo "BASE_URL=https://drb-qa.nypl.org/" >> "$GITHUB_ENV"
+          else
+              echo "BASE_URL=http://local.nypl.org:3000/" >> "$GITHUB_ENV"
+          fi
+
+      - name: Add hosts to /etc/hosts
+        if: github.ref != 'production'
+        run: |
+          sudo echo "127.0.0.1 local.nypl.org" | sudo tee -a /etc/hosts
+
       - name: Install Test Dependencies
-        run: npm i @cucumber/[email protected] @playwright/test@1.29.1
+        run: npm i @playwright/test@1.49.1
 
       - name: Install Playwright
         run: npx playwright install --with-deps
@@ -25,26 +38,17 @@ jobs:
         run: NODE_ENV=test npm run build
 
       - name: Start the app
+        if: github.ref != 'production'
         run: |
           NODE_ENV=test npm start &
           sleep 5
         shell: bash
 
       - name: Run your tests
         run: npm run playwright
-
-      - name: Set the world parameters as an env var
-        # WORLD_PARAMETERS set here will override anything set in cucumber.json
-        run: |
-          echo "WORLD_PARAMETERS={\"headless\": true}" >> $GITHUB_ENV
-
-      - name: Run Cucumber tests
-        run: npm run cucumber -- playwright/features --world-parameters '${{ env.WORLD_PARAMETERS }}'
         env:
           CATALOG_USERNAME: ${{ secrets.CATALOG_USERNAME }}
           CATALOG_USER_PIN: ${{ secrets.CATALOG_USER_PIN }}
-          CUCUMBER_PUBLISH_TOKEN: ${{ secrets.CUCUMBER_PUBLISH_TOKEN }}
-          CUCUMBER_PUBLISH_ENABLED: true
 
       - name: Slack Notification
         if: ${{ always() }}

CHANGELOG.md

@@ -3,6 +3,8 @@
 ## [Prerelease]
 
 - Remove survey banner
+- Replace Cucumber with Playwright Page Object Model tests
+- Update GH action to run tests against local.nypl.org and QA for prod PRs
 
 ## [0.18.10]
 

mocks/mockEnv.ts

@@ -1,4 +1,4 @@
-export const NYPL_LOGIN_URL = "https://login.nypl.org/auth/login?redirect_uri=";
+export const NYPL_LOGIN_URL = "login.nypl.org";
 export const API_URL = "https://backend.msw";
 export const FULFILL_PATH = "/fulfill/9351827";
 export const LIMITED_ACCESS_EDITION_PATH = "/edition/6977884";