Merge pull request #565 from NYPL/development

Release 0.18.9 to production

.eslintrc.json

@@ -0,0 +1,18 @@
+{
+  "extends": [
+    "eslint:recommended",
+    "next",
+    "next/core-web-vitals",
+    "next/typescript",
+    "plugin:jest-dom/recommended",
+    "plugin:jsx-a11y/strict",
+    "plugin:testing-library/dom",
+    "prettier",
+    "prettier/@typescript-eslint"
+  ],
+  "rules": {
+    // TODO: SFR-2318 enable in the future
+    "@typescript-eslint/no-explicit-any": "off",
+    "testing-library/no-node-access": "off"
+  }
+}

.github/workflows/Playwright.yml

@@ -1,8 +1,7 @@
 name: Playwright Tests for Digital Research Books
 
-# TODO: Remove https://drb-api-qa.nypl.org from behind the VPC
-# on:
-#   pull_request:
+on:
+  pull_request:
 
 jobs:
   tests:
@@ -26,20 +25,9 @@ jobs:
         run: NODE_ENV=test npm run build
 
       - name: Start the app
-        run: npm run dev &
-        shell: bash
-
-      - name: Wait for the app
         run: |
-          RETRIES=6
-          until curl --output /dev/null --silent --head --fail http://localhost:3000 || [ $((RETRIES--)) -eq 0 ]; do
-            echo "Waiting for http://localhost:3000"
-            sleep 5
-          done
-          if [ $RETRIES -lt 0 ]; then
-            echo "Failed to connect to http://localhost:3000"
-            exit 1
-          fi
+          NODE_ENV=test npm start &
+          sleep 5
         shell: bash
 
       - name: Run your tests

.github/workflows/build-qa.yml

@@ -53,3 +53,7 @@ jobs:
       - name: Force ECS Update
         run: |
           aws ecs update-service --cluster sfr-front-end-qa --service sfr-front-end-qa --force-new-deployment
+        
+      - name: Force ECS Update - Terraform
+        run: |
+          aws ecs update-service --cluster sfr-frontend-qa-tf --service sfr-frontend-qa-tf --force-new-deployment

CHANGELOG.md

@@ -1,5 +1,15 @@
 # CHANGE LOG
 
+## [Prerelease]
+
+## [0.18.9]
+
+- Enable playwright tests GH action
+- Remove unused scss and img files
+- Remove duplicate eslint packages, update eslint config, and resolve linting errors
+- Update survey banner to be more visible
+- Deploy to both ECS clusters in QA
+
 ## [0.18.8]
 
 - Add survey banner to Landing, Collection, Edition, Work, and Search pages