Scc 4142/spec coll messaging #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dgcohen
reviewed
Dec 17, 2024
src/models/ItemAvailability.tsx
Outdated
There was a problem hiding this comment.
Is there a reason this functionality needs its own class? I feel like the key building could be added to the item model with a component handling the presentation logic.
There was a problem hiding this comment.
it's so focused on a specific cluster of data that I think it justifies its own class. I am going to move the presentation logic to the component.
src/components/ItemTable/ItemAvailabilityComponents/ContactALibrarian.tsx
Outdated
Show resolved
Hide resolved
dgcohen
reviewed
Dec 18, 2024
src/components/ItemTable/ItemAvailabilityComponents/ContactALibrarian.tsx
Outdated
Show resolved
Hide resolved
|
Finding aid work was found to be out of scope for this, so closing this to open a new PR without those additions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary refactor to facilitate this ticket. Would love some eyes on this before I go all the way down this path.
To summarize, I created an ItemAvailability model which builds a string that represents it's availability, location, and special collections status. The model also handles returning the correct message component.
Ticket:
This PR does the following:
How has this been tested?
Accessibility concerns or updates
Checklist: