Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scc 3664/item filters #40

Closed
wants to merge 9 commits into from
Closed

Scc 3664/item filters #40

wants to merge 9 commits into from

Conversation

charmingduchess
Copy link
Contributor

@charmingduchess charmingduchess commented Nov 1, 2023

Beginning work for item filters. I stopped writing tests because I realized a lot of the behavior we will need to test is dependent on some more of the styling and api stuff to teased out.
The component is currently rendered in the advanced search page. For that reason, the advanced search page tests are failing. I'll remove the component from that page before merging.
Built out behavior:

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
research-catalog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 9:12pm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can you move this into the utils directory and make the filename and function names more specific to item filters?

Copy link
Contributor

@dgcohen dgcohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just a couple of small comments.

Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are minor. This is looking great!

src/types/filterTypes.ts Outdated Show resolved Hide resolved
src/components/ItemFilters/utils.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants