Scc 3773/utils testing

[charmingduchess]

• Added tests for appUtils,bibUtils, drbUtils, searchUtils.
• created test helper that checks query strings for matching key=value pairs. This is so we are not stuck on order if the order changes with the new query param parsing library.
• Not 100% sure if it's necessary, but i added some logic into getSearchQuery to exclude the sort_direction parameter if none is supplied.
• moved all tests to be in same directory as the file they're testing

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
research-catalog	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2023 2:17pm

[EdwinGuzman]

One minor naming comment. Otherwise, I'd prefer if the jest.config file can be updated to exclude specific files rather than nest __test__ in test. If it doesn't work then we can keep the nested directory but it makes it unclear why we need the nesting unless if you're writing tests.

[EdwinGuzman]

The more I look at this file the more complex the query object vs the url query is. All seems fine but just pointing out the complexity.

[charmingduchess]

how so?

[dgcohen]

Looks good! After our conversation, I think it makes sense to try to extend the jest configuration to allow for tests to be picked up in the pages directory. Could you look into that as part of this work?

Also, it just occurred to be that since jest picks up any tests with the test.tsx extension, we could probably co-locate the tests in the same directory as the component rather than putting it in a __test__ dir.

E.g.

What do you and @EdwinGuzman think?

[EdwinGuzman]

The other test PR resolves the comment above ✅