Merge pull request #417 from NYPL/SCC-4381/hold-page-vqa-fixes

SCC-4380 - Hold page VQA fixes
NYPL · Dec 12, 2024 · 4dba074 · 4dba074
2 parents 8afc6fe + a94fe3d
commit 4dba074
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 15 deletions.
diff --git a/src/components/HoldPages/CopyrightRestrictionsBanner.tsx b/src/components/HoldPages/CopyrightRestrictionsBanner.tsx
@@ -6,7 +6,7 @@ export const CopyrightRestrictionsBanner = () => {
       type="neutral"
       heading="Copyright restrictions"
       content={
-        <Box>
+        <Box mt="xs">
           <Text>
             The copyright law of the United States (Title 17, United States
             Code) governs the making of photocopies or other reproductions of

diff --git a/src/components/HoldPages/EDDRequestForm.tsx b/src/components/HoldPages/EDDRequestForm.tsx
@@ -118,7 +118,7 @@ const EDDRequestForm = ({
         value={eddFormState.source}
       />
       <Box>
-        <Heading level="h3" size="heading4" mb="m">
+        <Heading level="h3" size="heading4" mb="s">
           Required information
         </Heading>
         <Text noSpace>
@@ -197,8 +197,8 @@ const EDDRequestForm = ({
           ref={validatedInputRefs["chapterTitle"]}
         />
       </FormField>
-      <Box>
-        <Heading level="h3" size="heading4" mb="xs">
+      <Box mt="xs">
+        <Heading level="h3" size="heading4" mb="s">
           Optional information
         </Heading>
         <Text noSpace>

diff --git a/src/components/HoldPages/HoldConfirmationAccordionData.tsx b/src/components/HoldPages/HoldConfirmationAccordionData.tsx
@@ -17,8 +17,8 @@ export const holdConfirmationFAQData: AccordionDataProps[] = [
         </Text>
         <Text noSpace>
           The item will be listed as &quot;Ready for pickup&quot; under your
-          holds tab when it is available. You will receive an email confirmation
-          after your item has arrived.
+          requests tab when it is available. You will receive an email
+          confirmation after your item has arrived.
         </Text>
       </>
     ),
@@ -79,12 +79,15 @@ export const holdConfirmationFAQData: AccordionDataProps[] = [
           </ExternalLink>{" "}
           or call 917-ASK-NYPL (
           <ExternalLink href="tel:19172756975">917-275-6975</ExternalLink>).
-          Processed requests can also be canceled from the holds tab in your
+          Processed requests can also be canceled from the requests tab in your
           patron account.
         </Text>
         <Text noSpace>
-          For more information about our requesting services, please see
-          Requesting Research Materials.
+          For more information about our requesting services, please see{" "}
+          <ExternalLink href="https://www.nypl.org/research/services/request-materials">
+            Requesting Research Materials
+          </ExternalLink>
+          .
         </Text>
       </>
     ),

diff --git a/src/components/HoldPages/HoldConfirmationFAQ.tsx b/src/components/HoldPages/HoldConfirmationFAQ.tsx
@@ -15,7 +15,7 @@ interface HoldConfirmationFAQProps {
 const HoldConfirmationFAQ = ({ isEDD = false }: HoldConfirmationFAQProps) => {
   return (
     <Box data-testid={`${isEDD ? "edd" : "on-site"}-confirmation-faq`}>
-      <Heading level="h3" mb="l">
+      <Heading level="h3" size="heading4" mb="l">
         Frequently asked questions
       </Heading>
       <Accordion

diff --git a/src/config/constants.ts b/src/config/constants.ts
@@ -146,31 +146,33 @@ export const EDD_PAGE_HEADING = "Request scan"
 export const EDD_FORM_FIELD_COPY = {
   emailAddress: {
     label: "Email address",
-    placeholder: "theresa.smith@gmail.com",
+    placeholder: "Example: theresasmith@gmail.com",
     helperText:
       "Your request will be delivered to the email address you enter above.",
     invalidText:
-      "Enter a valid email address. Your request will be delivered to the email address you enter above.",
+      "There was a problem. Enter a valid email address. Your request will be delivered to the email address you enter above.",
   },
   startPage: {
     label: "Starting page number",
     placeholder: "Example: 1",
     helperText: "Enter the first page you would like scanned.",
-    invalidText: "Enter a page number. You may request a maximum of 50 pages.",
+    invalidText:
+      "There was a problem. Enter a page number. You may request a maximum of 50 pages.",
   },
   endPage: {
     label: "Ending page number",
     placeholder: "Example: 20",
     helperText: "Enter the last page you would like scanned.",
-    invalidText: "Enter a page number. You may request a maximum of 50 pages.",
+    invalidText:
+      "There was a problem. Enter a page number. You may request a maximum of 50 pages.",
   },
   chapterTitle: {
     label: "Chapter or article title",
     placeholder: "Example: Chapter 1",
     helperText:
       "Enter the name/number of the chapter or article you would like scanned.",
     invalidText:
-      "Indicate the title of the chapter or article you are requesting.",
+      "There was a problem. Indicate the title of the chapter or article you are requesting.",
   },
   author: {
     label: "Author",