Code

Show total count#13

Code

Open

holingpoon wants to merge 26 commits intomasterNYPL/php-microservice-starter:masterfrom show-total-countNYPL/php-microservice-starter:show-total-countCopy head branch name to clipboard

+146-8

Commits

Commits on Feb 27, 2018

• Adding row count to ModelSet.

  

  Ho-Ling Poon

  committed
  2641166

  Copy full SHA for 2641166

• Adding rowCount to DBReadTrait.

  

  Ho-Ling Poon

  committed
  879f794

  Copy full SHA for 879f794

• Adding include_count detection in filters.

  

  Ho-Ling Poon

  committed
  9dc0031

  Copy full SHA for 9dc0031

• Testing for total count to show up on data.

  

  Ho-Ling Poon

  committed
  90d5043

  Copy full SHA for 90d5043

Commits on Feb 28, 2018

• Preliminary version of showing total count with date range.

  

  Ho-Ling Poon

  committed
  e39e1eb

  Copy full SHA for e39e1eb

Commits on Mar 1, 2018

• Refactoring TotalCount as its own PHP class.

  

  Ho-Ling Poon

  committed
  54ea7bf

  Copy full SHA for 54ea7bf

• Adding conditionals to reflect only showing total count by query parameters.

  

  Ho-Ling Poon

  committed
  478096b

  Copy full SHA for 478096b

• Fixed formatting.

  

  Ho-Ling Poon

  committed
  1238708

  Copy full SHA for 1238708

• Showing totalCount only as a single number or null on API response.

  

  Ho-Ling Poon

  committed
  62793f0

  Copy full SHA for 62793f0

• First refactoring of obtainTotalCount.

  

  Ho-Ling Poon

  committed
  c6f6651

  Copy full SHA for c6f6651

• Renaming variable for easier reading and fitting local scope.

  

  Ho-Ling Poon

  committed
  b633d20

  Copy full SHA for b633d20

• Removing PHPStorm autogenerated text.

  

  Ho-Ling Poon

  committed
  c21ee68

  Copy full SHA for c21ee68

• Removing APILogger not used in DBTrait.

  

  Ho-Ling Poon

  committed
  15cc005

  Copy full SHA for 15cc005

Commits on Mar 2, 2018

• Removing TotalCount class. Moving total count related data back to ModelSet. Clearly assign boolean value to .

  

  Ho-Ling Poon

  committed
  9bb45bf

  Copy full SHA for 9bb45bf

• Removing mentions of TotalCount class. Saving ModelSet filter for next commit.

  

  Ho-Ling Poon

  committed
  69958d0

  Copy full SHA for 69958d0

• DBReadTrait::obtainTotalCount() refactored to use Slim\PDO\Statement\SelectStatement::count() aggregation feature, avoids returning full data set which can potentially crash API endpoint.

  

  Ho-Ling Poon

  committed
  44443f6

  Copy full SHA for 44443f6

• Refactoring SuccessResponse to detect Model, Model[] and ModelSet.

  

  Ho-Ling Poon

  committed
  a961cb3

  Copy full SHA for a961cb3

• Removing Debug messages.

  

  Ho-Ling Poon

  committed
  b0240de

  Copy full SHA for b0240de

• Only exposing data from ModelSet.

  

  Ho-Ling Poon

  committed
  239099d

  Copy full SHA for 239099d

• Refactor setData() to type specific initialization.

  

  Ho-Ling Poon

  committed
  c8b6ce7

  Copy full SHA for c8b6ce7

• Show current size of ModelSet in count.

  

  Ho-Ling Poon

  committed
  92596a2

  Copy full SHA for 92596a2

• Adding detection of ModelSet in SuccessResponse's constructor.

  

  Ho-Ling Poon

  committed
  fd3e7a4

  Copy full SHA for fd3e7a4

Commits on Mar 5, 2018

• Remove redundant checking of true value for .

  

  Ho-Ling Poon

  committed
  0bc7451

  Copy full SHA for 0bc7451

• Database lookup only returns count in obtainTotalCount().

  

  Ho-Ling Poon

  committed
  6f59192

  Copy full SHA for 6f59192

• Refactoring nested if-else structure, using early return from function instead. Checking for ModelSet first to avoid returning baseModel in response.

  

  Ho-Ling Poon

  committed
  6eb5fee

  Copy full SHA for 6eb5fee

• Typecasting to ensure safe assignments.

  

  Ho-Ling Poon

  committed
  4d82517

  Copy full SHA for 4d82517