Rm validation flag

[charmingduchess]

Description

• rm validation flag from patron creator service api request
• rm hidden input that is based on the application state hasUsernameBeenValidated
• move loading switch to the catch statement

Motivation and Context

Dupe accounts were slipping in due to a combination of the following:

• scenario 1:
  • inline validation successful, saved in state
  • user posted their account
  • navigated back
  • submitted again, and state still has hasUsernameBeenValidated: true, so account is posted again, api does not revalidate, dupe patron created
• scenario 2:
  • loading layer disappears before router.push to congrats page, allowing a validated username to be submitted again

How Has This Been Tested?

Manual testing. No additional unit tests created. Should there be some?

Checklist:

• I have updated the documentation accordingly.
• All new and existing tests passed.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nypl-library-card-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 9, 2025 5:06pm