Skip to content

Commit

Permalink
Merge pull request #13 from NYPL/master
Browse files Browse the repository at this point in the history
Merge latest from Master to Production
  • Loading branch information
ktp242 authored Dec 18, 2018
2 parents d7c02ed + 30c67bd commit 6df03ae
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 5 deletions.
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
## CHANGE LOG

### v0.4.16
- Updating @nypl/dgx-header-component to 2.4.15 and checking for QA in APP_ENV.

### v0.4.15
- Updating @nypl/dgx-header-component to 2.4.14 and setting APP_ENV.

### v0.4.14
- Updating @nypl/dgx-header-component to 2.4.13.

### v0.4.13
- Updating @nypl/dgx-header-component to 2.4.12.

### v0.4.12
- Update to use green from Design Toolkit

### v0.4.11
- Updates to form: add radio button, change ptype selection logic from query parameter to radio button
- Copy updates
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ a patron record.
https://www.nypl.org/library-card/new/

## Version
> 0.4.10
> 0.4.16
| Branch | Status |
|:--------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------|
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nypl-library-card-app",
"version": "0.4.10",
"version": "0.4.16",
"description": "NYPL Get A Library Card App",
"main": "index.js",
"scripts": {
Expand Down Expand Up @@ -56,7 +56,7 @@
},
"dependencies": {
"@nypl/design-toolkit": "0.1.36",
"@nypl/dgx-header-component": "2.4.11",
"@nypl/dgx-header-component": "2.4.15",
"@nypl/dgx-react-footer": "0.5.1",
"axios": "0.15.3",
"babel-core": "6.24.0",
Expand Down
6 changes: 4 additions & 2 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ const path = require('path');
const webpack = require('webpack');
const CleanBuild = require('clean-webpack-plugin');
const ExtractTextPlugin = require('extract-text-webpack-plugin');

// Sets appEnv so the the header component will point to the search app on either Dev or Prod
const appEnv = process.env.APP_ENV ? process.env.APP_ENV : 'production';
const rootPath = path.resolve(__dirname);
const sassPaths = require('@nypl/design-toolkit').includePaths.map((sassPath) =>
`includePaths[]=${sassPath}`
).join('&');

// PRODUCTION ENVIRONMENT CONFIG
if (process.env.NODE_ENV === 'production') {
module.exports = {
devtool: 'source-map',
Expand Down Expand Up @@ -44,6 +44,7 @@ if (process.env.NODE_ENV === 'production') {
new CleanBuild(['dist']),
new webpack.DefinePlugin({
'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV),
appEnv: JSON.stringify(appEnv),
}),
new webpack.optimize.DedupePlugin(),
new webpack.optimize.OccurenceOrderPlugin(),
Expand Down Expand Up @@ -92,6 +93,7 @@ if (process.env.NODE_ENV === 'production') {
new CleanBuild(['dist']),
new webpack.DefinePlugin({
'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV),
appEnv: JSON.stringify(appEnv),
}),
new webpack.HotModuleReplacementPlugin(),
],
Expand Down

0 comments on commit 6df03ae

Please sign in to comment.