DSD-1877: Filtering Style Guide #1712
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bigfishdesign13
added
the
Needs Review
bigfishdesign13
requested review from
EdwinGuzman,
oliviawongnyc,
jackiequach and
7emansell
There was a problem hiding this comment.
These are great. Thank you for writing this and the imagery makes the docs easy to read. Do you think we need some gifs with examples on doc pages such as the accessibility for focus management? Another example, on the pagination page, it could use information about where focus should go after a button is clicked (the total results heading). Focus management is something that comes up a lot so I want to make it clear what our recommendation for that is as well.
Before approving, I want all FE devs to read through this, make sure they understand the approach, and approve it since it's a guideline for their apps: @7emansell @dgcohen @avertrees @charmingduchess @jackiequach @isastettler @Toxiapo
There was a problem hiding this comment.
Can you create a Filtering subfolder in StyleGuide for all these files? Then you don't have to repeat the prefix for every file.
EdwinGuzman
requested review from
dgcohen,
Toxiapo,
avertrees,
isastettler and
charmingduchess
| ## Clearing filters | ||
|
|
||
| Filters can be cleared using various methods within the page structure, | ||
| including global methods as well as methods for clearing individual filters. |
There was a problem hiding this comment.
I'm curious: If a user searches for a term and applies some filters, but then continues typing in the search box without clearing the filters, should the filters be reset? Not sure if this is a accessibility question or a product question.
| ## Focus management | ||
|
|
||
| ### Applying search terms |
There was a problem hiding this comment.
We’ll eventually need to build a custom filtering modal (we’re currently using an Ionic component) for the Reader, and this will be a great reference for accessibility!
There was a problem hiding this comment.
Agree, great to see these AC consolidated here.
|
|
||
| ### Mobile | ||
|
|
||
| For mobile viewports, the filter bar will display a "Show result" button and can |
There was a problem hiding this comment.
Should this say "Show results"?
Fixes JIRA ticket DSD-1877
This PR does the following:
Filteringpage to theStyle Guide.How has this been tested?
Accessibility concerns or updates
Accessibility Checklist
aria-liveis used, a screenreader was used to verify the text is read.refs, focus management was reviewed.Open Questions
Checklist:
Front End Review: