DSD-1702: responsive grid system #1591
Open
+34,450
−38,922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* development: better ts formatting added docs for Visited State Patterns changelog updates updated color styles for NoBrand button updated placeholder for search field
* development: updates based on comments formatting better layout for Icon examples
Release 3.1.1
DSD-1740/close dropdown multiselect
DSD-1740: Adds ability to close MultiSelect on blur
DSD-1746: FeedbackBox interaction tests
DSD-1795: Breadcrumbs Digital Collections variant
jest routing npm package update
| @@ -4,6 +4,9 @@ import { defineStyle } from "@chakra-ui/system"; | |||
| * Grid layout based on https://www.joshwcomeau.com/css/full-bleed/ | |||
| */ | |||
|
|
|||
| export const responsiveGutters = { base: "1rem", md: "1.5rem", xl: "1rem" }; | |||
There was a problem hiding this comment.
@bigfishdesign13, just checking – the gutters are meant to get bigger at the md breakpoint and smaller at xl?
There was a problem hiding this comment.
Yes, that was the intention. The md: "1.5rem" here aligns with the md: "1.5rem" in responsiveSpacing. But I'll admit, I was a bit wishy washy on this. Maybe it should just be "1rem" across the board.
bigfishdesign13
added
On Hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA ticket DSD-1702
This PR does the following:
Templatecomponent to implement a new responsive grid system.Templatecomponent to explain how the new responsive grid system will work and how to use the legacy "grid" layout.responsiveGuttersandresponsiveSpacingdata objects to make available to consuming apps.Responsive Gridpage to theStyle Guide.How has this been tested?
Accessibility concerns or updates
Checklist:
Front End Review: