DSD-1719/adds container queries to searchbar #1589
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your pull request is missing a changelog—was that intentional? |
EdwinGuzman
reviewed
May 6, 2024
EdwinGuzman
reviewed
May 6, 2024
| @@ -217,6 +217,7 @@ export const SearchBar: React.FC<any> = chakra( | |||
| invalidText={invalidText} | |||
| isInvalid={isInvalid} | |||
| ref={ref} | |||
| sx={{ containerType: "inline-size" }} | |||
There was a problem hiding this comment.
It seems to me that container queries are so new that Chakra does not support them as style props. Is that true?
This doesn't have to be part of this ticket but we should update all components so that devs can do <Component wrapper containerType="inline-size" ...>. It might mean having a global base interface with the container query attributes and all component interfaces inherit from it. Maybe? This is a nice-to-have update.
jackiequach
changed the base branch from
development
to
container-query-feature-branch
…-with-container-queries
…-with-container-queries
…-with-container-queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA ticket DSD-1719
This PR does the following:
SearchBar, not meant to be mergedChecklist:
Front End Review: