Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakpoints & Grid Feature Branch #1565

Open
wants to merge 18 commits into
base: reservoir-v4
Choose a base branch
from
Open

Breakpoints & Grid Feature Branch #1565

wants to merge 18 commits into from
+311 −77

Conversation

bigfishdesign13
Copy link
Collaborator

This PR does the following:

  • Updates the values for the breakpoints and the associated docs.
  • Updates the viewport preview options in Storybook to align with the Reservoir breakpoints.

How has this been tested?

  • local Storybook

Accessibility concerns or updates

  • n/a

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@bigfishdesign13 bigfishdesign13 added the In Progress Tickets or PRs that are being worked on. PRs marked as In Progress should not be merged. label Mar 25, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 8:01pm

@bigfishdesign13 bigfishdesign13 marked this pull request as draft April 17, 2024 20:26
@bigfishdesign13 bigfishdesign13 changed the base branch from development to reservoir-v4 December 20, 2024 18:43
@bigfishdesign13 bigfishdesign13 marked this pull request as ready for review December 20, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
In Progress Tickets or PRs that are being worked on. PRs marked as In Progress should not be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigfishdesign13 @EdwinGuzman