Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.1.1 #1451

Merged
merged 34 commits into from
Oct 30, 2023
Merged

Release v2.1.1 #1451

merged 34 commits into from
Oct 30, 2023

Conversation

bigfishdesign13
Copy link
Collaborator

This PR does the following:

Adds

  • Adds a changelog to the story pages for the Heading component.

Updates

  • Updates the Heading component to set the aria-roledescription value as "subtitle" (a more familiar and recognizable value) for the overline element.
  • Updates the FeedbackBox and NewsletterSignup components to set the tabindex on the internal elements to "-1".
  • Updates DatePicker's TextInput to always have an aria-label attribute that tells screen reader users how to access the calendar.
  • Updates Storybook to v7.5.1.

Fixes

  • Fixes a bug in the Hero component where custom background colors were not rendering properly in dark mode for the "campaign" and "tertiary" variants.

Deprecates

  • Deprecates the "secondary" and "fiftyFifty" variants of the Hero component.

bigfishdesign13 and others added 30 commits October 16, 2023 16:52
DSD-1610: better aria attributes for Heading overline
…box-tabindex

DSD-1606: tabindex for FeedbackBox and NewsletterSignup
DSD-1572: deprecate secondary and fiftyFifty variants for Hero
DSD-1579: Adds aria-label to input for DatePicker
DSD-1608: Hero custom background colors in dark mode
DSD-1614: Upgrading to Storybook v7.5.1
@bigfishdesign13 bigfishdesign13 added the Release PRs for prod releases and release prep label Oct 26, 2023
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 2:30pm

@bigfishdesign13 bigfishdesign13 added the DON’T MERGE YET When somethign has been approved, but should not be merged just yet. label Oct 26, 2023
@bigfishdesign13 bigfishdesign13 merged commit 24125ed into release Oct 30, 2023
3 checks passed
@bigfishdesign13 bigfishdesign13 added Ship It Pull requests that have been reviewed and approved. and removed DON’T MERGE YET When somethign has been approved, but should not be merged just yet. labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release PRs for prod releases and release prep Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants