Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSD-1608: Hero custom background colors in dark mode #1446

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

bigfishdesign13
Copy link
Collaborator

Fixes JIRA ticket DSD-1608

This PR does the following:

  • Fixes a bug in the Hero component where custom background colors were not rendering properly in dark mode for the "campaign" and "tertiary" variants.

How has this been tested?

  • local build of Storybook

Accessibility concerns or updates

  • n/a

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 1:40pm

Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good. I haven't looked too closely at this but the sub headings don't seem to have the right color. I take a closer look tomorrow.

Screen Shot 2023-10-23 at 7 55 09 PM

@bigfishdesign13 bigfishdesign13 added Ship It Pull requests that have been reviewed and approved. and removed Needs Review Pull requests that are ready for peer review. labels Oct 25, 2023
@bigfishdesign13 bigfishdesign13 merged commit e9f3714 into development Oct 25, 2023
@bigfishdesign13 bigfishdesign13 deleted the DSD-1608/hero-tertiary-background branch October 25, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants